Skip to content

[TOOL-3398] Dashboard: Fix DialogOverlay and DialogContent missing default shadcn z-index #6239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2025
Merged

[TOOL-3398] Dashboard: Fix DialogOverlay and DialogContent missing default shadcn z-index #6239

merged 1 commit into from
Feb 12, 2025

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Feb 12, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on enhancing the Dialog component's styling by adding a z-index to ensure it appears above other elements when open.

Detailed summary

  • Added z-50 to the className of the main Dialog component.
  • Added z-50 to the className of the DialogContent component.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Feb 12, 2025

TOOL-3398 UI issue: ecosystem partners title overlapping with add partner popup

@changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: e9ab8cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 12, 2025
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 12, 2025 16:01 Inactive
@vercel
Copy link

vercel bot commented Feb 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 9:10pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 12, 2025 9:10pm
login ⬜️ Skipped (Inspect) Feb 12, 2025 9:10pm
thirdweb_playground ⬜️ Skipped (Inspect) Feb 12, 2025 9:10pm
wallet-ui ⬜️ Skipped (Inspect) Feb 12, 2025 9:10pm

@MananTank Graphite App
Copy link
Member Author

MananTank commented Feb 12, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vercel vercel bot temporarily deployed to Preview – docs-v2 February 12, 2025 16:01 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 12, 2025 16:01 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 12, 2025 16:01 Inactive
@MananTank MananTank marked this pull request as ready for review February 12, 2025 16:01
@MananTank MananTank requested review from a team as code owners February 12, 2025 16:01
@MananTank MananTank added the hotfix This pull request should be prioritized in the merge queue. label Feb 12, 2025 — with Graphite App
@MananTank Graphite App
Copy link
Member Author

MananTank commented Feb 12, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Feb 12, 11:02 AM EST: The merge label 'hotfix' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 12, 4:07 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 12, 4:11 PM EST: A user merged this pull request with the Graphite merge queue.

@codecov
Copy link

codecov bot commented Feb 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.88%. Comparing base (9c33981) to head (e9ab8cb).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6239   +/-   ##
=======================================
  Coverage   56.88%   56.88%           
=======================================
  Files        1166     1166           
  Lines       64507    64507           
  Branches     5226     5226           
=======================================
  Hits        36698    36698           
  Misses      27081    27081           
  Partials      728      728
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 9c33981
packages 55.10% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 2.8 s (+28.67% 🔺) 3.8 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 6.2 s (+9.39% 🔺) 8.6 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 432 ms (+6.47% 🔺) 544 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 123 ms (+166.45% 🔺) 133 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 754 ms (+77.92% 🔺) 1.2 s

@graphite-app graphite-app bot force-pushed the 02-12-_tool-3398_dashboard_fix_dialogoverlay_and_dialogcontent_missing_default_shadcn_z-index branch from ddf7b8b to e9ab8cb Compare February 12, 2025 21:08
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 12, 2025 21:08 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 12, 2025 21:08 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 12, 2025 21:08 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 12, 2025 21:08 Inactive
@graphite-app graphite-app bot merged commit e9ab8cb into main Feb 12, 2025
32 checks passed
@graphite-app graphite-app bot deleted the 02-12-_tool-3398_dashboard_fix_dialogoverlay_and_dialogcontent_missing_default_shadcn_z-index branch February 12, 2025 21:11
@vercel vercel bot temporarily deployed to Production – wallet-ui February 12, 2025 21:11 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground February 12, 2025 21:11 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 February 12, 2025 21:11 Inactive
@vercel vercel bot temporarily deployed to Production – login February 12, 2025 21:11 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xFirekeeper 0xFirekeeper 0xFirekeeper approved these changes

Assignees

@MananTank MananTank

Labels

Dashboard Involves changes to the Dashboard. hotfix This pull request should be prioritized in the merge queue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @0xFirekeeper